add more logging to oauth controller

This commit is contained in:
Stanley Dimant
2024-12-20 10:39:47 +01:00
parent f292b5b275
commit 0cdf0d1667

View File

@@ -45,6 +45,8 @@ public class OAuthController : AuthControllerBase
if (discordClientSecret == null || discordClientId == null || discordOAuthUri == null) if (discordClientSecret == null || discordClientId == null || discordOAuthUri == null)
return BadRequest("Server does not support OAuth2"); return BadRequest("Server does not support OAuth2");
Logger.LogDebug("Starting OAuth Process for {session}", sessionId);
var cookieOptions = new CookieOptions var cookieOptions = new CookieOptions
{ {
HttpOnly = true, HttpOnly = true,
@@ -86,6 +88,8 @@ public class OAuthController : AuthControllerBase
if (string.IsNullOrEmpty(reqId)) return BadRequest("No session cookie found"); if (string.IsNullOrEmpty(reqId)) return BadRequest("No session cookie found");
if (string.IsNullOrEmpty(code)) return BadRequest("No Discord OAuth2 code found"); if (string.IsNullOrEmpty(code)) return BadRequest("No Discord OAuth2 code found");
Logger.LogDebug("Discord OAuth Callback for {session}", reqId);
var query = HttpUtility.ParseQueryString(discordOAuthUri.Query); var query = HttpUtility.ParseQueryString(discordOAuthUri.Query);
using var client = new HttpClient(); using var client = new HttpClient();
var parameters = new Dictionary<string, string> var parameters = new Dictionary<string, string>
@@ -103,6 +107,7 @@ public class OAuthController : AuthControllerBase
if (!response.IsSuccessStatusCode) if (!response.IsSuccessStatusCode)
{ {
Logger.LogDebug("Failed to get Discord token for {session}", reqId);
return BadRequest("Failed to get Discord token"); return BadRequest("Failed to get Discord token");
} }
@@ -116,6 +121,7 @@ public class OAuthController : AuthControllerBase
if (!meResponse.IsSuccessStatusCode) if (!meResponse.IsSuccessStatusCode)
{ {
Logger.LogDebug("Failed to get Discord user info for {session}", reqId);
return BadRequest("Failed to get Discord user info"); return BadRequest("Failed to get Discord user info");
} }
@@ -129,6 +135,7 @@ public class OAuthController : AuthControllerBase
} }
catch (Exception ex) catch (Exception ex)
{ {
Logger.LogDebug(ex, "Failed to parse Discord user info for {session}", reqId);
return BadRequest("Failed to parse user id from @me response for token"); return BadRequest("Failed to parse user id from @me response for token");
} }
@@ -139,7 +146,11 @@ public class OAuthController : AuthControllerBase
var mareUser = await dbContext.LodeStoneAuth.Include(u => u.User).SingleOrDefaultAsync(u => u.DiscordId == discordUserId); var mareUser = await dbContext.LodeStoneAuth.Include(u => u.User).SingleOrDefaultAsync(u => u.DiscordId == discordUserId);
if (mareUser == null) if (mareUser == null)
{
Logger.LogDebug("Failed to get Mare user for {session}, DiscordId: {id}", reqId, discordUserId);
return BadRequest("Could not find a Mare user associated to this Discord account."); return BadRequest("Could not find a Mare user associated to this Discord account.");
}
var jwt = CreateJwt([ var jwt = CreateJwt([
new Claim(MareClaimTypes.Uid, mareUser.User!.UID), new Claim(MareClaimTypes.Uid, mareUser.User!.UID),
@@ -166,6 +177,7 @@ public class OAuthController : AuthControllerBase
_cookieOAuthResponse.TryRemove(reqId, out _); _cookieOAuthResponse.TryRemove(reqId, out _);
}); });
Logger.LogDebug("Setting JWT response for {session}, process complete", reqId);
return Ok("The OAuth2 token was generated. The plugin will grab it automatically. You can close this browser tab."); return Ok("The OAuth2 token was generated. The plugin will grab it automatically. You can close this browser tab.");
} }
@@ -205,19 +217,25 @@ public class OAuthController : AuthControllerBase
[HttpGet(MareAuth.OAuth_GetDiscordOAuthToken)] [HttpGet(MareAuth.OAuth_GetDiscordOAuthToken)]
public async Task<IActionResult> GetDiscordOAuthToken([FromQuery] string sessionId) public async Task<IActionResult> GetDiscordOAuthToken([FromQuery] string sessionId)
{ {
Logger.LogDebug("Starting to wait for GetDiscordOAuthToken for {session}", sessionId);
using CancellationTokenSource cts = new(); using CancellationTokenSource cts = new();
cts.CancelAfter(TimeSpan.FromSeconds(60)); cts.CancelAfter(TimeSpan.FromSeconds(55));
while (!_cookieOAuthResponse.ContainsKey(sessionId) && !cts.Token.IsCancellationRequested) while (!_cookieOAuthResponse.ContainsKey(sessionId) && !cts.Token.IsCancellationRequested)
{ {
await Task.Delay(TimeSpan.FromSeconds(1), cts.Token); await Task.Delay(TimeSpan.FromSeconds(1), cts.Token);
} }
if (cts.IsCancellationRequested) if (cts.IsCancellationRequested)
{ {
Logger.LogDebug("Timeout elapsed for {session}", sessionId);
return BadRequest("Did not find Discord OAuth2 response"); return BadRequest("Did not find Discord OAuth2 response");
} }
_cookieOAuthResponse.TryRemove(sessionId, out var token); _cookieOAuthResponse.TryRemove(sessionId, out var token);
if (token == null) if (token == null)
{
Logger.LogDebug("No token found for {session}", sessionId);
return BadRequest("OAuth session was never established"); return BadRequest("OAuth session was never established");
}
Logger.LogDebug("Returning JWT for {session}, process complete", sessionId);
return Content(token); return Content(token);
} }